Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CoinUtils -- 2.11.11 #8067

Closed

Conversation

amontoison
Copy link
Contributor

Copy link
Contributor

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for resolution of #8066 (comment)

Copy link
Contributor

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay try this now

@odow
Copy link
Contributor

odow commented Feb 9, 2024

A list of the order is:

  1. [CoinUtils_jll]
  2. [Osi_jll]
  3. [Clp_jll]
  4. [Cgl_jll]
  5. [Cbc_jll]
  6. [Bonmin_jll]
  7. [Couenne_jll]
  8. [SHOT_jll]
  9. [SYMPHONY_jll]
  10. [ALPS_jll]
  11. [BiCePS_jll]
  12. [CHIPPS_BLIS_jll]
  13. [MibS_jll]

The other COIN-OR packages are

  1. [Ipopt_jll]
  2. [IpoptMKL_jll]
  3. [CDSP_jll]

@ViralBShah
Copy link
Member

IpOptMKL can probably be deprecated by linking IpOpt against LBT.

@ViralBShah
Copy link
Member

I believe you have to merge CoinUtils first, and then use it in the other packages in the dependency chain - and keep doing that repeatedly.

@amontoison
Copy link
Contributor Author

Ipopt_jll is already linked with LBT so we could remove the folder for the artifact IpoptMKL_jll.

Yes, I discussed with Oscar a few days ago and we will start with CoinUtils, OsiUtils and Clp.

@ViralBShah
Copy link
Member

We can just let IpOptMKL be around, but just not update it going forward.

@odow
Copy link
Contributor

odow commented Feb 16, 2024

I believe you have to merge CoinUtils first, and then use it in the other packages in the dependency chain - and keep doing that repeatedly.

Yeah, @amontoison has this under control, but they're traveling etc over the next few weeks. There is no rush.

@imciner2
Copy link
Member

Ipopt_jll is already linked with LBT so we could remove the folder for the artifact IpoptMKL_jll.

Has anyone tested running the LBT build with MKL selected? We should make sure we don't see the same problem that SLICOT had when using MKL with LBT (e.g. JuliaLinearAlgebra/MKL.jl#138).

@amontoison
Copy link
Contributor Author

Ipopt_jll is already linked with LBT so we could remove the folder for the artifact IpoptMKL_jll.

Has anyone tested running the LBT build with MKL selected? We should make sure we don't see the same problem that SLICOT had when using MKL with LBT (e.g. JuliaLinearAlgebra/MKL.jl#138).

Excellent remark @imciner2!
But we compile all COIN-OR packages with LP64 BLAS / LAPACK and not ILP64 BLAS / LAPACK so we can't have this problem.

I also checked with nm -D libCoinUtils.so.3.11.10 and only two symbols (related to dense LU) are used:

U dgetrf_
U dgetrs_

@imciner2
Copy link
Member

But we compile all COIN-OR packages with LP64 BLAS / LAPACK and not ILP64 BLAS / LAPACK so we can't have this problem.

I also checked with nm -D libCoinUtils.so.3.11.10 and only two symbols (related to dense LU) are used:

Excellent, then it should be safe to deprecate the old IpOptMKL and just use the main build from now on. IMO, I agree we can leave the build scripts there, but I think we should add a DEPRECATED file to the folder explaining the deprecation and that the normal IpOpt should be used instead.

@ViralBShah
Copy link
Member

Should we merge this and then merge the Clp PR?

@odow
Copy link
Contributor

odow commented Jun 4, 2024

There's now 2.11.11 so we should probably first update to that
https://github.com/coin-or/CoinUtils/releases/tag/releases%2F2.11.11

@amontoison
Copy link
Contributor Author

amontoison commented Jun 4, 2024

I will update the PR tomorrow. Sorry, I forgot that I started to work on the LBT support in COIN-OR packages.

C/Coin-OR/coin-or-common.jl Outdated Show resolved Hide resolved
C/Coin-OR/coin-or-common.jl Outdated Show resolved Hide resolved
@amontoison amontoison changed the title Upgrade CoinUtils -- 2.11.10 Upgrade CoinUtils -- 2.11.11 Jun 20, 2024
@amontoison amontoison closed this Jul 16, 2024
@amontoison amontoison deleted the upgrade_coinutils branch July 16, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants