Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCV] Rebuild JLL for 1.10 compatibility #7152

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[OpenCV] Rebuild JLL for 1.10 compatibility #7152

merged 2 commits into from
Aug 10, 2023

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Aug 2, 2023

@benlorenz
Copy link
Contributor

You could also add support for julia 1.11 nightlies by adding it to the julia_versions line, or by removing that line since the version list is set by libjulia/common.jl automatically if it doesn't exist (https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/libjulia/common.jl#L10).

@stemann
Copy link
Contributor Author

stemann commented Aug 7, 2023

You could also add support for julia 1.11 nightlies by adding it to the julia_versions line, or by removing that line since the version list is set by libjulia/common.jl automatically if it doesn't exist (https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/libjulia/common.jl#L10).

Removed the line.

@vchuravy vchuravy merged commit d26cb2e into JuliaPackaging:master Aug 10, 2023
@vchuravy
Copy link
Member

I would almost recommend moving the libjulia dependent part into a separate jll

@stemann stemann deleted the patch-1 branch August 10, 2023 14:28
@stemann
Copy link
Contributor Author

stemann commented Aug 10, 2023

I would almost recommend moving the libjulia dependent part into a separate jll

Not sure I understand what you mean here... Sounds like a separate issue to be filed? (with a slightly more elaborate explanation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants