Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ONNXRuntime (cpu) #4369

Merged
merged 10 commits into from
Feb 13, 2022
Merged

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Feb 5, 2022

No description provided.

O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
@stemann stemann force-pushed the stemann/onnxruntime branch 4 times, most recently from ad5498b to c4c7fe8 Compare February 6, 2022 11:23
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
@stemann stemann requested a review from giordano February 6, 2022 12:50
@stemann stemann force-pushed the stemann/onnxruntime branch 5 times, most recently from 96b8c8c to 75401e5 Compare February 6, 2022 14:17
@stemann stemann force-pushed the stemann/onnxruntime branch 3 times, most recently from 3a34030 to eff8c95 Compare February 6, 2022 15:48
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
@stemann stemann force-pushed the stemann/onnxruntime branch from dbbd895 to fd23dff Compare February 6, 2022 17:12
@stemann stemann requested a review from giordano February 6, 2022 17:51
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/onnxruntime/build_tarballs.jl Outdated Show resolved Hide resolved
@stemann stemann force-pushed the stemann/onnxruntime branch from a8c0f0b to 4fa1849 Compare February 7, 2022 17:30
@stemann stemann requested a review from giordano February 7, 2022 18:03
@stemann
Copy link
Contributor Author

stemann commented Feb 7, 2022

I will squash the branch, once we get through the review - I have a manual rebase on hand.

@stemann stemann changed the title Added onnxruntime (cpu) Added ONNXRuntime (cpu) Feb 7, 2022
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now

O/ONNXRuntime/ONNXRuntime/build_tarballs.jl Outdated Show resolved Hide resolved
O/ONNXRuntime/ONNXRuntime/build_tarballs.jl Show resolved Hide resolved
@stemann stemann mentioned this pull request Feb 9, 2022
@stemann stemann force-pushed the stemann/onnxruntime branch 3 times, most recently from 5af5a81 to 0a6acef Compare February 13, 2022 21:42
@stemann stemann marked this pull request as ready for review February 13, 2022 21:47
stemann and others added 10 commits February 13, 2022 22:48
Also:
* Updated for BinaryBuilder v0.5 - using provided cmake.
* Replaced download during build with additional sources.

Co-authored-by: Mosè Giordano <[email protected]>
Includes:
* Building aarch64-apple-darwin from source
* Added workaround for arm-linux-gnueabihf
* Disabled build of unit tests
* Replaced custom protoc with protoc_jll
* Restricted expansion of CXX string ABIs to Linux

Co-authored-by: Mosè Giordano <[email protected]>
… script

Also, made the binary install a bit more verbose.
@stemann stemann force-pushed the stemann/onnxruntime branch from 0a6acef to 39d6668 Compare February 13, 2022 21:48
@stemann stemann requested a review from giordano February 13, 2022 21:48
@giordano giordano merged commit cc4e6f6 into JuliaPackaging:master Feb 13, 2022
@stemann stemann deleted the stemann/onnxruntime branch February 13, 2022 22:19
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
* Added build script based on build.sh

* Fixed build script by using CMake directly - circumventing build.sh script

* Added re-packaging of Microsoft-provided packages for troublesome platforms

* Merged source and binary scripts into one

Also:
* Updated for BinaryBuilder v0.5 - using provided cmake.
* Replaced download during build with additional sources.

Co-authored-by: Mosè Giordano <[email protected]>

* Re-introduced the onnxruntime python-based build script

Includes:
* Building aarch64-apple-darwin from source
* Added workaround for arm-linux-gnueabihf
* Disabled build of unit tests
* Replaced custom protoc with protoc_jll
* Restricted expansion of CXX string ABIs to Linux

Co-authored-by: Mosè Giordano <[email protected]>

* Renamed to ONNXRuntime

* Reverted to the CMake approach - circumventing the python-based build script

Also, made the binary install a bit more verbose.

* Removed explicit define of onnxruntime_CROSS_COMPILING=OFF

* Enabled RTTI for all platforms

* Implemented unpack trick for avoiding dist_name conditional in shell script

Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants