-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MKL to 2021.1.1 #2308
Update MKL to 2021.1.1 #2308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but it seems they once again changed the files structure in the Window package...
Looks like the windows now has the same paths for the licenses. |
What's the reason to make MKL a lazy artifact? Shouldn't we always install it when required? |
Oh yeah, like it was last year: 6c03359. They seem to like moving files back and forth |
MKL is proprietary, it's large, it's a dependency of |
Ah it is an optional dependency there. Makes sense. My thought was that in a package that explicitly depends on MKL, it felt odd to see the download at runtime. For example, SuiteSparse upstream recommends against openblas, and I recently ran into a major performance issue in Circuitscape.jl, which had to be resolved by building SuiteSparse with MKL. That's why I have a renewed interest in MKL. |
I wonder why it can't find
|
Yes, it should be called
|
No description provided.