Fix a JET warning #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'else' path, JET cannot prove that SCRATCH_DIR_OVERRIDE[] is (still) 'nothing', and thus reports a possible error. This then is also shown when analyzing packages that use Scratch. This can be resolved by assigning it first to a temporary variable.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 87.61% 87.73% +0.11%
==========================================
Files 1 1
Lines 105 106 +1
==========================================
+ Hits 92 93 +1
Misses 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hmm, seems Scratch is broken on Julia nightly? |
|
@staticfloat @fredrikekre @giordano any concerns about this PR? Otherwise I'd like to merge it and make a new release, to get my package "JET clean" ;-) |
|
Looks good to me. |
|
Looks fine to me; shall we add a JET pass to the CI in a follow-on PR so that we don't accidentally regress it? |
fredrikekre
approved these changes
Oct 30, 2023
|
@staticfloat I've added JET to the test suite, let me know if that's what you had in mind. |
giordano
reviewed
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 'else' path, JET cannot prove that SCRATCH_DIR_OVERRIDE[] is
(still) 'nothing', and thus reports a possible error. This then is also
shown when analyzing packages that use Scratch. This can be resolved by
assigning it first to a temporary variable.