[Sources] Ban GitHub-generated archives as sources #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Jan 31, 2023
giordano
force-pushed
the
mg/no-github-archives
branch
from
d007a5c
to
a062722
Compare
aviks
reviewed
Jan 31, 2023
| # <https://github.com/bazel-contrib/SIG-rules-authors/issues/11#issuecomment-1029861300> | ||
| # the `/archive/refs/tag` should be more stable, but that didn't happen in the incident | ||
| # on 2023-01-30, so it's unclear whether we can trust them. | ||
| if contains(url, r"github.com/[^/]+/[^/]+/archive/(refs/tag/)?[^/]+\.(tar\.gz|zip)$") |
There was a problem hiding this comment.
This won't match manually uploaded release tarballs, right?
There was a problem hiding this comment.
Correct, those are /download/, like the file now used as test in https://github.com/JuliaPackaging/BinaryBuilderBase.jl/pull/293/files#diff-5a745ed885ee2954c186a5c488dfb2f3d6c85e220cc63f5dc427035597ff0d1cR28
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.