[Auditor] Do not skip GCC libraries when updating linkage #1240
Conversation
| @@ -313,31 +311,6 @@ end | |||
| # Determine whether a library is a "default" library or not, if it is we need | |||
| # to map it to `@rpath/$libname` on OSX or `\$ORIGIN/$libname` on Linux/FreeBSD | |||
| is_default_lib(lib, oh) = false | |||
There was a problem hiding this comment.
I honestly don't understand what's the purpose of this function.
There was a problem hiding this comment.
This method is for when oh is not a MachOHandle or an ELFHandle; e.g. when it's a COFFHandle, or some other handle type that we add in the future to ObjectFile
There was a problem hiding this comment.
The method yes, I understand, but not the function as a whole. With this PR this is the only method of this function, so we can just remove it entirely
| unpack(tarball_path, testdir) | ||
| # Make sure auditor set the rpath of `hello_world`, even if it links only to | ||
| # libgfortran. | ||
| @test Auditor._rpaths(joinpath(testdir, "bin", "hello_world_fortran")) == ["\$ORIGIN/../lib"] |
There was a problem hiding this comment.
Without the change, the RPATH would be empty because all required libraries would be skipped.
|
Thanks! |
| @@ -313,31 +311,6 @@ end | |||
| # Determine whether a library is a "default" library or not, if it is we need | |||
| # to map it to `@rpath/$libname` on OSX or `\$ORIGIN/$libname` on Linux/FreeBSD | |||
| is_default_lib(lib, oh) = false | |||
There was a problem hiding this comment.
This method is for when oh is not a MachOHandle or an ELFHandle; e.g. when it's a COFFHandle, or some other handle type that we add in the future to ObjectFile
|
Looks like we need to update the locked gitshas in some other tests? |
The failing tests were gfortran builds on Linux which changed the SHA, but not the Windows ones, which is all consistent with the changes in this PR. Isn't it exciting? 😃 |
|
This PR is highlighting that so far for the most part we were relying on some system GCC libraries (like |
|
Thanks for hunting all that down |
I feel like these libraries were skipped in the old days before CompilerSupportLibraries was a thing. Ref: JuliaPackaging/Yggdrasil#3703 (comment). CC: @vtjnash @apaz-cli