use cholesky and bump version

JuliaNonconvex · May 14, 2022 · fa148c3 · fa148c3 · mohamed82008 · May 14, 2022
1 parent e383164
commit fa148c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "NonconvexSemidefinite"
 uuid = "9e21ff56-eb25-42d3-b86f-5b0612f555e7"
 authors = ["Mohamed Tarek <[email protected]> and contributors"]
-version = "0.1.6"
+version = "0.1.7"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/NonconvexSemidefinite.jl b/src/NonconvexSemidefinite.jl
@@ -149,9 +149,9 @@ catch err
 end
 function ChainRulesCore.rrule(rc::RuleConfig, ::typeof(safe_logdet), A::AbstractMatrix)
     try
-        return rrule_via_ad(rc, logdet, A)
+        return rrule_via_ad(rc, A -> logdet(cholesky(A)), A)
     catch
-        -Inf, _ -> (NoTangent(), similar(A) .= NaN)
+        return -Inf, _ -> (NoTangent(), similar(A) .= NaN)
     end
 end