Skip to content

Commit

Permalink
minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
mohamed82008 committed Nov 10, 2023
1 parent 95f0c22 commit 8c5d7e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NonconvexCore"
uuid = "035190e5-69f1-488f-aaab-becca2889735"
authors = ["Mohamed Tarek <[email protected]> and contributors"]
version = "1.4.1"
version = "1.4.2"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand Down
7 changes: 2 additions & 5 deletions src/functions/functions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ end
Calls the wrapped functions in `f` with arguments `args` and keyword arguments `kwargs` and returns the concatenated output.
"""
function (f::VectorOfFunctions)(args...; kwargs...)
length(f.fs) == 0 && return Union{}[]
ys = map(f.fs) do f
out = f(args...; kwargs...)
length(out) == 0 ? Union{}[] : out
return f(args...; kwargs...)
end
return vcat(ys...)
end
Expand Down Expand Up @@ -282,7 +282,6 @@ Returns the function wrapped in `f`.
"""
getfunction(f::EqConstraint) = f.f


"""
Used in semidefinite programming
Expand All @@ -294,8 +293,6 @@ end

function (c::SDConstraint)(args...; kwargs...)
out = c.f(args...; kwargs...)
# println(length(out))
# println(getdim(c))
@assert length(out) == getdim(c)^2
return out
end
Expand Down

2 comments on commit 8c5d7e4

@mohamed82008
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/95126

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.4.2 -m "<description of version>" 8c5d7e414728b4f4efe7942872e2d32ac3f81835
git push origin v1.4.2

Please sign in to comment.