Hyperopt support #57
Closed
Hyperopt support #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed82008
commented
Jun 3, 2021
| @warn "Due to you are performing hyperparameter optimization on starting point, the x0 passed to function `optimize` will be ignored. " | ||
| end | ||
| # Process lower bound and upper bound, if the bounds are not specified, then use bounds of model instead | ||
| @assert !(x0_lb === nothing && isempty(model.box_min)) || (x0_rb === nothing && isempty(model.box_max)) |
There was a problem hiding this comment.
use getmin and getmax
mohamed82008
commented
Jun 3, 2021
There was a problem hiding this comment.
Looks good overall. But check https://github.com/baggepinnen/Hyperopt.jl#hyperband to see how to change the resources using HyperBand. Then we also want the multi-threaded and distributed versions of hyperopt.
|
Closed in favor of #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #37. GitHub acted weird when I pushed to the PR branch a merge commit. The PR was closed and I am unable to reopen it so I am opening another one. CC: @noil-reed