Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qpm() docs #171

Merged
merged 2 commits into from
May 30, 2024
Merged

Add qpm() docs #171

merged 2 commits into from
May 30, 2024

Conversation

NeroBlackstone
Copy link
Member

Please confirm the changes to ensure that I understand correctly

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is correct, the code doesn't account for tempo changes. Perhaps it should?

Do we have a function that returns

    for event in t.tracks[1].events
        if event isa SetTempoEvent
            push!(list, 6e7 / event.tempo)
        end
    end
return list

so that a user may find all tempo changes and have a list of QPM over time?

@NeroBlackstone
Copy link
Member Author

Yes that is correct, the code doesn't account for tempo changes. Perhaps it should?

Do we have a function that returns

    for event in t.tracks[1].events
        if event isa SetTempoEvent
            push!(list, 6e7 / event.tempo)
        end
    end
return list

so that a user may find all tempo changes and have a list of QPM over time?

I think tempochanges() function already implemented what you said, so I think It's okay to just add the doumentation to remind users.

@Datseris Datseris merged commit 3868e9e into JuliaMusic:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants