Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and test negative octaves. closes #144 #145

Merged
merged 3 commits into from
Jul 11, 2021

Conversation

tp2750
Copy link
Contributor

@tp2750 tp2750 commented Jul 10, 2021

This fixes #144 : name_to_pitch fails for negative octave

It includes a test for a relevant set of pitches:

@test all([name_to_pitch(pitch_to_name(i)) == i for i in 0:88])

Before patch:

julia> join(name_to_pitch.([pitch_to_name(i)  for i in 0:24]), ", ")
"24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24"

With patch:

julia> join(name_to_pitch.([pitch_to_name(i)  for i in 0:24]), ", ")
"0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24"

@Datseris
Copy link
Member

Thank you! Please increment patch version in Project.toml so I can merge and tag!

@tp2750
Copy link
Contributor Author

tp2750 commented Jul 11, 2021

Thanks a lot @Datseris . Version number updated to 2.0.1.

@Datseris Datseris merged commit 3464239 into JuliaMusic:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name_to_pitch fails for negative octave
2 participants