Add warnings for default value functions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 60.75% 60.28% -0.47%
==========================================
Files 8 8
Lines 558 564 +6
==========================================
+ Hits 339 340 +1
- Misses 219 224 +5
Continue to review full report at Codecov.
|
|
great, also increment patch version on project.toml |
|
I've incremented it from 1.12.2 to 1.12.3 in the PR @Datseris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added the warnings for all of the functions that return a default value as mentioned in #137.
Now the functions would warn the user and also return the default value.