Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read/write for .MID and .midi files #136

Merged
merged 3 commits into from
Apr 18, 2021

Conversation

VasanthManiVasi
Copy link
Member

Hi, previously we were able to read .mid files and write both .mid and .MID files. Now we can read/write .mid, .MID and .midi files.
.MID and .midi are also quite common so it would be great to be able to read/write them. The extensions differ only by their name so the filename check was alone changed.

@Datseris
Copy link
Member

Datseris commented Apr 18, 2021

Thanks for this. Perhaps it is about time to extend FileIO.jl for MIDI files. We could then export its save and load functions that dispatch on "magic numbers" for .mid endings. https://github.com/JuliaIO/FileIO.jl

Not really a priority, but if you are interested feel free to have a look at the FileIO docs and open a pr here and there, it is surprisingly simple.


(also please increment patch number here)

@Datseris Datseris added I/O Related to read and write functionality bug Bug report, or fixes a bug (if Pull Request) labels Apr 18, 2021
@VasanthManiVasi
Copy link
Member Author

VasanthManiVasi commented Apr 18, 2021

Sure, I'll take a look at FileIO.jl. They allow passing a list of extensions when registering a new file format so we can add .mid, .MID and .midi too.

@Datseris Datseris merged commit 4eecf26 into JuliaMusic:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report, or fixes a bug (if Pull Request) I/O Related to read and write functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants