Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function to read time signature #130

Merged
merged 5 commits into from
Apr 1, 2021
Merged

add function to read time signature #130

merged 5 commits into from
Apr 1, 2021

Conversation

VasanthManiVasi
Copy link
Member

Added a function to read the time signature as mentioned in #110. Rationals are reduced (4//4 becomes 1//1), so it returns a string instead.

Datseris
Datseris reviewed Mar 31, 2021
View reviewed changes
src/midifile.jl Outdated Show resolved Hide resolved
@Datseris
Copy link
Member

Thank you very much for this contribution! please also increment minor version in Project.toml and add an entry in the Changelog!

@VasanthManiVasi
Copy link
Member Author

Thanks! I've updated them accordingly.

@Datseris Datseris merged commit 629bba3 into JuliaMusic:master Apr 1, 2021
@VasanthManiVasi
Copy link
Member Author

Thanks for the merge @Datseris! Is #110 safe to close?

@Datseris
Copy link
Member

Datseris commented Apr 1, 2021

New MIDI.jl version is out including your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Datseris Datseris Datseris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasanthManiVasi @Datseris