Remove 960 ticks upper limit for tpq. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 960 ticks upper limit for tpq, add tpq keyword argument for `Notes()` constructor function.
Datseris
reviewed
Dec 14, 2019
src/note.jl
Outdated
| end | ||
| Notes{N}(notes, tpq) | ||
| end | ||
|
|
||
| Notes() = Notes{Note}(Vector{Note}[], 960) | ||
| Notes() = Notes{Note}(Vector{Note}[], tpq = 960) |
There was a problem hiding this comment.
This is not a keyword constructor. In fact, this change does not achieve anything, it is syntactically equivalent with the above. What you want to do instead is define:
Notes(;tpq = 960) = Notes{Note}(Vector{Note}[], tpq)The keyword arguments are defined on the function definition (left hand side), not on the function call (right hand side).
There was a problem hiding this comment.
Oh yes you are right. It's corrected.
Datseris
reviewed
Dec 14, 2019
|
Alright, LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 960 ticks upper limit for tpq, add tpq keyword argument for
Notes()constructor function.