-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IrrationalConstants and LogExpFunctions.log1mexp #345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 92.90% 92.45% -0.46%
==========================================
Files 12 12
Lines 2722 2717 -5
==========================================
- Hits 2529 2512 -17
- Misses 193 205 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(Aren't a bunch of these constants also used in |
This PR uses IrrationalConstants, which is already an indirect dependency of SpecialFunctions through LogExpFunctions 0.3, for values such as
sqrt(pi)
orpi/2
and removes the definition oflog1mexp
in favour ofLogExpFunctions.log1mexp
.Moreover, I noticed three occurrences of
log(1-...)
and replaced them withlog1p(-...)
.