-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename lgamma to log(abs)gamma #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I noticed that logabsdet
actually returns a tuple of log(abs(det(x))), sign(det(x))
. I'm not sure if we want to do the same thing here, or would it be better as a separate function?
@simonbyrne made the changes!! |
@simonbyrne made the other changes except for removing Also I can't replace So, one possible fix can be to make |
@simonbyrne issue is resolved I guess. Renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good to me. I'll give it a day or two to see if anyone else has comments.
@simonbyrne this is fine now! Updated the docs too. |
Thanks for your persistence here, looks great! |
Ensure consistency with #156.
Ensure consistency with #156.
Ensure consistency with #156.
Ping @simonbyrne .
If the changes are valid and right to do, I'll add another commit for doing the same for
lbeta
andlbinomial
, or maybe I can make those changes in a separate PR.Fixes #154