Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After being heavily nerd-sniped by @s-celles, here is a quadratic sieve implementation. It's already a good bit faster than my ECM implementation in #104 for semi-primes (and there still is some relatively low hanging fruit for further optimization, specifically looking for
x^2 - m*N
and using multiple polynomials). Unfortunately for factoring big numbers with lots of factors it's fairly slow (so probably needs combining with ECM with a low bound)