Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divisors: add doctest filter #140

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

fingolfin
Copy link
Contributor

... to filter out annotations added to the doctest output

Let's see how that works, I may have to tweak it.

src/Primes.jl Outdated Show resolved Hide resolved
src/Primes.jl Outdated Show resolved Hide resolved
src/Primes.jl Outdated Show resolved Hide resolved
@fingolfin
Copy link
Contributor Author

It seems I have hit a Documenter bug or two. I'll make an alternate PR for now until I can get this here properly resolved.

src/Primes.jl Outdated
@@ -968,7 +968,7 @@ For convenience, `divisors(0)` returns `[]`.

# Example

```jldoctest
```jldoctest; filter = r"\\s+#.*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```jldoctest; filter = r"\\s+#.*"
```jldoctest; filter = r"(\\s+#.*)?"

... to filter out annotations added to the doctest output
@fingolfin fingolfin marked this pull request as ready for review September 28, 2023 23:18
@fingolfin
Copy link
Contributor Author

Got this working now, @oscardssmith

@oscardssmith oscardssmith merged commit e89b703 into JuliaMath:master Sep 29, 2023
4 checks passed
@oscardssmith
Copy link
Member

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants