-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The iterator eachfactor
is not type-stable
#151
Comments
byhill
changed the title
The iterator
The iterator Feb 21, 2024
eachfactor
doesn't match it's eltype
.eachfactor
doesn't respect it's eltype
.
byhill
changed the title
The iterator
The iterator Feb 21, 2024
eachfactor
doesn't respect it's eltype
.eachfactor
is not type-stable
ah good catch. This was mostly tested on Int64 inputs. Fixing this should be pretty easy. |
oscardssmith
added a commit
that referenced
this issue
Feb 21, 2024
* fix `eachfactor` type stability fixes #151. (test incoming) * add test
fixed and version tagged (Pkg should know about it in ~1 hr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following code.
The
eachfactor
iterator should return (at least based on it'seltype
)Tuple{Int32,Int64}
but it returns a mixture ofTuple{Int32,Int64}
andTuple{Int64,Int64}
.The text was updated successfully, but these errors were encountered: