Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Base.IteratorSize method #35

Merged
merged 2 commits into from
Aug 29, 2018
Merged

add Base.IteratorSize method #35

merged 2 commits into from
Aug 29, 2018

Conversation

kdw503
Copy link
Contributor

@kdw503 kdw503 commented Aug 28, 2018

Add a Base.IteratorSize method to resolve an error in calling issubset() method in julia-0.7.

@timholy
Copy link
Member

timholy commented Aug 28, 2018

Worth pointing out that this will work in conjunction with JuliaLang/julia#28871.

It is worth adding a test. Until new versions of Julia are released, the test will fail (unfortunately). You could mark it @test_broken right now, and then you or someone can change it to @test once Julia gets fixed. Near your test, insert a comment like # see issue #35 so that anyone reading the source code knows to look here for an explanation.

@timholy timholy merged commit b981da8 into JuliaMath:master Aug 29, 2018
@timholy
Copy link
Member

timholy commented Aug 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants