Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and improve ilog2(::Real) #9

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Simplify and improve ilog2(::Real) #9

merged 2 commits into from
Aug 19, 2024

Commits on Aug 2, 2023

  1. Simplify and improve ilog2(::Real) 

    * Simplify ilog2 for built in bitstype floats and BigFloat by calling exponent.

* Some missing tests are added for RoundUp and RoundDown with floating point arguments.
  An undetected bug was fixed and is tested by these tests.

In fact, it's hard to identify a clear advantage of any of the remaining methods compared
to `ilog2(x:Any) = exponent(float(x::Any))`.

Closes JuliaMath#8
    @jlapeyre
    jlapeyre committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e7d7cd6 View commit details
    Browse the repository at this point in the history

  2. Fix type piracy

    @jlapeyre
    jlapeyre committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f952293 View commit details
    Browse the repository at this point in the history