Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hcubature_count and hcubature_print #75

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

mikeingold
Copy link
Contributor

@mikeingold mikeingold commented Dec 13, 2024

Changes

  • Implements an hcubature_count function, as suggested by hcubature_count #68, which counts the number of integrand function evaluations and returns (I, E, count).
  • Implements an hcubature_print function, shamelessly adapted from QuadGK.quadgk_print (credit to @stevengj), which prints a line f($x) = $(f(x)) for every integrand function evaluation and returns (I, E, count).

@mikeingold mikeingold changed the title WIP: Implement hcubature_count and hcubature_print Implement hcubature_count and hcubature_print Dec 14, 2024
@mikeingold mikeingold marked this pull request as ready for review December 14, 2024 00:55
test/runtests.jl Outdated Show resolved Hide resolved
@mikeingold
Copy link
Contributor Author

I added another test for the hcubature_print method without an io arg to address test coverage. This test suppresses stdout for that particular call to avoid cluttering the test logs.

@stevengj stevengj merged commit 680baaf into JuliaMath:master Dec 17, 2024
8 checks passed
@stevengj stevengj mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants