Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Fixed --> Float conversions #172

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

kimikage
Copy link
Collaborator

Closes #171.

@kimikage
Copy link
Collaborator Author

kimikage commented Jan 22, 2020

Of course, there are minor breaking changes regarding the improvement of numerical errors.

julia> Float32(-0x1p-25)
-2.9802322f-8

julia> Float32(-eps(Q6f25)) # error (on FixedPointNumbers v0.7.1)
0.0f0

julia> Float32(eps(Q6f25))
2.9802322f-8

@codecov-io
Copy link

Codecov Report

Merging #172 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   88.32%   88.39%   +0.06%     
==========================================
  Files           5        5              
  Lines         377      379       +2     
==========================================
+ Hits          333      335       +2     
  Misses         44       44
Impacted Files Coverage Δ
src/fixed.jl 87.65% <100%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb29336...8e01b89. Read the comment docs.

@kimikage kimikage merged commit 62cef1c into JuliaMath:master Feb 2, 2020
@kimikage kimikage deleted the issue171 branch February 2, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimizing Fixed --> Float conversions
3 participants