Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printf reorg / add Project.toml #99

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Printf reorg / add Project.toml #99

merged 1 commit into from
Oct 27, 2019

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented Oct 19, 2019 •
edited
Loading

Base.Printf was removed with JuliaLang/julia#33313.

Julia nightly now requires Project.toml JuliaLang/Pkg.jl#1356.

Fixes #98

@coveralls
Copy link

coveralls commented Oct 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 203

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+12.8%) to 77.073%
Files with Coverage Reduction New Missed Lines %
src/DecFP.jl 10 77.07%
Totals Coverage Status
Change from base Build 198: 12.8%
Covered Lines: 158
Relevant Lines: 205
💛 - Coveralls

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Oct 20, 2019

The Travis build failure on macOS Julia 1.0 is unrelated to this PR.

@quinnj quinnj merged commit 24f9f94 into JuliaMath:master Oct 27, 2019
@wookay
Copy link

wookay commented Oct 27, 2019

thanks!

@stevengj stevengj mentioned this pull request Apr 8, 2020
Closed
@jmkuhn jmkuhn deleted the printfreorg branch May 23, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to stdlib Printf
4 participants
@jmkuhn @coveralls @wookay @quinnj