Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to have this return
Integers
instead of floating point values. Most uses of this function are probably looking for integers and this avoids the inefficiency of converting an integer to floating point which the user immediately converts back to integer. One consequence of returning integers is that this function throws aDomainError
forInf
orNaN
inputs. The user would need to check for and handle these values anyway; this just encourages the check before callingsigexp
.Fixes #130
cc @quinnj