Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low-level Constructors #129

Merged
merged 2 commits into from
May 25, 2020
Merged

Low-level Constructors #129

merged 2 commits into from
May 25, 2020

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented May 18, 2020

No description provided.

@jmkuhn jmkuhn requested review from quinnj and stevengj May 18, 2020 12:17
@jmkuhn
Copy link
Contributor Author

jmkuhn commented May 18, 2020

Closes #14.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented May 18, 2020

All of the CI failures were errors installing Julia. The runs where Julia installed, CI passed.

src/DecFP.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmkuhn jmkuhn mentioned this pull request May 20, 2020
src/DecFP.jl Show resolved Hide resolved
@stevengj stevengj merged commit 228e308 into JuliaMath:master May 25, 2020
@stevengj
Copy link
Member

👍

@jmkuhn jmkuhn deleted the llconst branch May 25, 2020 17:51
@jmkuhn jmkuhn mentioned this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants