Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparision with Float #117

Closed
wants to merge 1 commit into from
Closed

Comparision with Float #117

wants to merge 1 commit into from

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented May 7, 2020 •
edited
Loading

No description provided.

@stevengj
Copy link
Member

stevengj commented May 8, 2020

This is still not an exact comparison, though, right? e.g. I don't think exp2(1000) is exactly representable as Dec128, so won't your code incorrectly return true for d128"1.071508607186267320948425049060002e301" == exp2(1000)?

@jmkuhn
Copy link
Contributor Author

jmkuhn commented May 8, 2020

Yes, good catch. I'll try a different approach.

@jmkuhn jmkuhn closed this May 11, 2020
@jmkuhn jmkuhn deleted the compare branch June 17, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmkuhn @stevengj