Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison with Rational #114

Merged
merged 1 commit into from
May 5, 2020
Merged

Comparison with Rational #114

merged 1 commit into from
May 5, 2020

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented May 5, 2020 •
edited
Loading

When I write a full set of tests for hash(), they will test decompose() more completely. Fixes #108

@stevengj
Copy link
Member

stevengj commented May 5, 2020 •
edited
Loading

It's unfortunate that BigInt is required here, but I don't see much alternative since the hashing algorithms in Base are designed for binary floating point.

In principle, the Rational comparisons could avoid BigInt, if we re-implemented those, no? (The BigInt version is fine for now, but it would be nice to keep in mind possible future improvements.)

@jmkuhn jmkuhn merged commit 2e8bd12 into JuliaMath:master May 5, 2020
@jmkuhn jmkuhn deleted the cmprat branch May 6, 2020 02:36
@jmkuhn jmkuhn mentioned this pull request May 13, 2020
Merged
@stevengj stevengj mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison with Rational
2 participants
@jmkuhn @stevengj