Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make thread-safe; use JLL package #106

Merged
merged 7 commits into from
Mar 29, 2020
Merged

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented Mar 5, 2020

Fixes #39 #47.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Mar 5, 2020

Even though this passes, don't merge. It looks like the way I am defining my global arrays precompiles with the value of Threads.ntheads() from the first time I run it.

Edit: fixed by resize!ing in __init__().

src/DecFP.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

src/DecFP.jl Outdated Show resolved Hide resolved
src/DecFP.jl Outdated Show resolved Hide resolved
src/DecFP.jl Outdated Show resolved Hide resolved
src/DecFP.jl Outdated Show resolved Hide resolved
@quinnj
Copy link
Collaborator

quinnj commented Mar 25, 2020

Bump, is this good to go now?

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Mar 25, 2020

I believe this is good to go.

@ViralBShah
Copy link
Member

Merge?

Project.toml Outdated Show resolved Hide resolved
src/DecFP.jl Outdated Show resolved Hide resolved
src/DecFP.jl Show resolved Hide resolved
src/DecFP.jl Outdated Show resolved Hide resolved
@jmkuhn
Copy link
Contributor Author

jmkuhn commented Mar 28, 2020

I'm not sure what the issue is with the Windows nightly runs, but I don't think it is related to this PR.

@stevengj stevengj merged commit 8eca99e into JuliaMath:master Mar 29, 2020
@jmkuhn jmkuhn deleted the threads branch November 30, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DecFP package thread safe
4 participants