-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixdeps 0.7 #40
Fixdeps 0.7 #40
Conversation
REQUIRE
Outdated
@@ -1,3 +1,2 @@ | |||
BinDeps | |||
julia 0.4 | |||
Compat 0.8 | |||
julia 0.7- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be julia 0.7
(no hyphen), in order to only accept released versions.
src/Cubature.jl
Outdated
@@ -1,4 +1,4 @@ | |||
VERSION >= v"0.4.0-dev+6521" && __precompile__() | |||
__precompile__() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this line since precompile is the default in 0.7.
src/Cubature.jl
Outdated
@@ -180,7 +180,7 @@ function cubature{F}(xscalar::Bool, fscalar::Bool, | |||
val, err) | |||
else | |||
ret = ccall((:pcubature,libcubature), Int32, | |||
(UInt32, Ptr{Void}, Any, | |||
(UInt32, Ptr{Nothing}, Any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Ptr{Cvoid}
.
You also need to update the |
It seems that |
Now it's a macro: |
Is there anything else I should add/change? |
One can also add |
I've been using this branch for a while and it seems pretty stable. Any chance it could be merged into master soon? |
Thanks! |
Removed all dep warnings for 0.7
I've followed this guide until step 5:
https://discourse.julialang.org/t/updating-packages-from-julia-v0-6-to-0-7/5103
Thanks for this great package! I hope that helps.