Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixdeps 0.7 #40

Merged
merged 7 commits into from
Mar 27, 2019
Merged

Fixdeps 0.7 #40

merged 7 commits into from
Mar 27, 2019

Conversation

scheidan
Copy link
Contributor

Removed all dep warnings for 0.7

I've followed this guide until step 5:
https://discourse.julialang.org/t/updating-packages-from-julia-v0-6-to-0-7/5103

Thanks for this great package! I hope that helps.

REQUIRE Outdated
@@ -1,3 +1,2 @@
BinDeps
julia 0.4
Compat 0.8
julia 0.7-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be julia 0.7 (no hyphen), in order to only accept released versions.

src/Cubature.jl Outdated
@@ -1,4 +1,4 @@
VERSION >= v"0.4.0-dev+6521" && __precompile__()
__precompile__()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line since precompile is the default in 0.7.

src/Cubature.jl Outdated
@@ -180,7 +180,7 @@ function cubature{F}(xscalar::Bool, fscalar::Bool,
val, err)
else
ret = ccall((:pcubature,libcubature), Int32,
(UInt32, Ptr{Void}, Any,
(UInt32, Ptr{Nothing}, Any,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Ptr{Cvoid}.

@stevengj
Copy link
Member

You also need to update the .travis.yml and appveyor.yml files. Just copy the ones from https://github.com/stevengj/HCubature.jl

@scheidan
Copy link
Contributor Author

It seems that Base.info exists in 0.7 but was removed in 1.0 which breaks the package installation.
Nor sure how to find it again... Of course we could simply remove the infos.

@giordano
Copy link
Member

giordano commented Sep 2, 2018

It seems that Base.info exists in 0.7 but was removed in 1.0 which breaks the package installation.
Nor sure how to find it again...

Now it's a macro: @info.

@scheidan
Copy link
Contributor Author

Is there anything else I should add/change?

@JanisErdmanis
Copy link

JanisErdmanis commented Nov 18, 2018

One can also add Project.toml and Manifest.toml files to make the package compatible with the new Pkg.

Cubature.zip

@gwater
Copy link

gwater commented Feb 19, 2019

I've been using this branch for a while and it seems pretty stable. Any chance it could be merged into master soon?

@stevengj stevengj merged commit dacf789 into JuliaMath:master Mar 27, 2019
@stevengj
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants