Refine documentation

Project.toml

@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.10.7"
+version = "0.10.9"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/DecoratorManifold.jl

@@ -574,6 +574,21 @@ decorated_manifold(M::Manifold) = M.manifold
     m::LogarithmicInverseRetraction,
 )
 
+@decorator_transparent_signature inverse_retract(
+    M::AbstractDecoratorManifold,
+    p,
+    q,
+    m::NLsolveInverseRetraction,
+)
+
+@decorator_transparent_signature inverse_retract!(
+    M::AbstractDecoratorManifold,
+    X,
+    p,
+    q,
+    m::NLsolveInverseRetraction,
+)
+
 @decorator_transparent_signature isapprox(M::AbstractDecoratorManifold, p, q; kwargs...)
 @decorator_transparent_signature isapprox(M::AbstractDecoratorManifold, p, X, Y; kwargs...)
 

src/DefaultManifold.jl

@@ -46,13 +46,13 @@ embed!(::DefaultManifold, Y, p, X) = copyto!(Y, X)
 
 exp!(::DefaultManifold, q, p, X) = (q .= p .+ X)
 
-function get_basis(M::DefaultManifold, p, B::DefaultOrthonormalBasis)
+function get_basis(::DefaultManifold, p, B::DefaultOrthonormalBasis)
     return CachedBasis(B, [_euclidean_basis_vector(p, i) for i in eachindex(p)])
 end
-function get_basis(M::DefaultManifold, p, B::DefaultOrthogonalBasis)
+function get_basis(::DefaultManifold, p, B::DefaultOrthogonalBasis)
     return CachedBasis(B, [_euclidean_basis_vector(p, i) for i in eachindex(p)])
 end
-function get_basis(M::DefaultManifold, p, B::DefaultBasis)
+function get_basis(::DefaultManifold, p, B::DefaultBasis)
     return CachedBasis(B, [_euclidean_basis_vector(p, i) for i in eachindex(p)])
 end
 function get_basis(M::DefaultManifold, p, B::DiagonalizingOrthonormalBasis)
@@ -61,12 +61,12 @@ function get_basis(M::DefaultManifold, p, B::DiagonalizingOrthonormalBasis)
     return CachedBasis(B, DiagonalizingBasisData(B.frame_direction, eigenvalues, vecs))
 end
 
-function get_coordinates!(M::DefaultManifold, Y, p, X, B::DefaultOrthonormalBasis)
+function get_coordinates!(M::DefaultManifold, Y, ::Any, X, ::DefaultOrthonormalBasis)
     copyto!(Y, reshape(X, manifold_dimension(M)))
     return Y
 end
 
-function get_vector!(M::DefaultManifold, Y, p, X, B::DefaultOrthonormalBasis)
+function get_vector!(M::DefaultManifold, Y, ::Any, X, ::DefaultOrthonormalBasis)
     copyto!(Y, reshape(X, representation_size(M)))
     return Y
 end