-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for optionally static size #160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 99.96% 99.84% -0.12%
==========================================
Files 19 20 +1
Lines 2539 2553 +14
==========================================
+ Hits 2538 2549 +11
- Misses 1 4 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you started this.
While I think this is quite technical and should not concern beginners, it might be nice for advanced usages.
A small benchmark illustrating when which is nicer might be nice as well (if that can be well-illustrated)
Yes, it's definitely not for beginners. |
Sure let's just keep that a bit in mind to explain this feature with a benchmark somewhen. |
Sure, I will add a clear explanation with an example in the Manifolds.jl PR that converts key manifolds to |
Basic infrastructure for solving JuliaManifolds/Manifolds.jl#625 .