Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project_point! #3

Closed
mateuszbaran opened this issue Nov 11, 2019 · 2 comments
Closed

project_point! #3

mateuszbaran opened this issue Nov 11, 2019 · 2 comments

Comments

@mateuszbaran
Copy link
Member

At the moment project_point! is a little out of line because it operates on its only argument in-place while other functions generally assume that mutated output is separate. Should we change it? Or maybe provide both variants?
@sethaxen
Copy link
Member

I'd say let's change it for consistency. I think this will also make it easier to support mutating and non-mutating variants as discussed in JuliaManifolds/Manifolds.jl#42

@mateuszbaran
Copy link
Member Author

In what way could it make it easier to support mutating and non-mutating variants? To me it looks like two independent issues.

@mateuszbaran mateuszbaran mentioned this issue Nov 15, 2019
Merged
mateuszbaran added a commit that referenced this issue Nov 16, 2019
@mateuszbaran
Merge pull request #7 from JuliaNLSolvers/mbaran/project_point
fe36f66 
fixed #3 (three-argument project_point!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mateuszbaran @sethaxen