Skip to content

Commit

Permalink
Refine documentation (#69)
Browse files Browse the repository at this point in the history
* add a definition to the retraction documentation.
* elaborate on the geodesic.
* move abstract approximate retractions to base.
* Refactor for better docs.
* fix a typo and clarify what the differential is.
* Apply suggestions from code review
* Document what parallel transport is

Co-authored-by: Mateusz Baran <[email protected]>
  • Loading branch information
kellertuer and mateuszbaran authored May 23, 2021
1 parent a805e8e commit 194e27e
Show file tree
Hide file tree
Showing 9 changed files with 541 additions and 383 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ManifoldsBase"
uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
version = "0.11.2"
version = "0.11.3"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
15 changes: 15 additions & 0 deletions src/DecoratorManifold.jl
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,21 @@ decorated_manifold(M::AbstractManifold) = M.manifold
m::LogarithmicInverseRetraction,
)

@decorator_transparent_signature inverse_retract(
M::AbstractDecoratorManifold,
p,
q,
m::NLsolveInverseRetraction,
)

@decorator_transparent_signature inverse_retract!(
M::AbstractDecoratorManifold,
X,
p,
q,
m::NLsolveInverseRetraction,
)

@decorator_transparent_signature isapprox(M::AbstractDecoratorManifold, p, q; kwargs...)
@decorator_transparent_signature isapprox(M::AbstractDecoratorManifold, p, X, Y; kwargs...)

Expand Down
Loading

2 comments on commit 194e27e

@kellertuer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/37309

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.3 -m "<description of version>" 194e27e985292e5e1685cf10e7bf27d4af40b9f7
git push origin v0.11.3

Please sign in to comment.