Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bases for CholeskySpace and LogCholesky metric #780
Bases for CholeskySpace and LogCholesky metric #780
Changes from 1 commit
e93c1de
6a8bbf5
d2271c5
7937238
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Unchanged files with check annotations Beta
Check warning on line 134 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L124-L134
Check warning on line 148 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L137-L148
Check warning on line 258 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L258
Check warning on line 269 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L267-L269
Check warning on line 275 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L275
Check warning on line 278 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L277-L278
Check warning on line 285 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L285
Check warning on line 287 in src/manifolds/CholeskySpace.jl
src/manifolds/CholeskySpace.jl#L287
Check warning on line 240 in src/manifolds/SymmetricPositiveDefinite.jl
src/manifolds/SymmetricPositiveDefinite.jl#L239-L240
Check warning on line 40 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L40
Check warning on line 67 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L67
Check warning on line 80 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L80
Check warning on line 91 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L87-L91
Check warning on line 94 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L94
Check warning on line 106 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L101-L106
Check warning on line 129 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L129
Check warning on line 158 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L158
Check warning on line 200 in src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl#L200