-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor make.jl #766
Refactor make.jl #766
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 124 124
Lines 11512 11512
=======================================
Hits 11099 11099
Misses 413 413 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Mateusz Baran <[email protected]>
And our News.md is out of sync, it states news for 0.10.6 which it seems are maybe part of 10.5? Will check tomorrow. This does not need to be released as its own version and can chill on main for a while though. It is just nicer for new contributors. |
I forgot to bump version in Project.toml to 0.10.6 in the last PR so maybe let's release 0.10.6 after merging this PR? |
Sure, I adapted news and project.toml. |
The integration test is annoying me I can not find any hint how to fix that it fails. Why is the extension complaining having a package in its dependencies that it literally extends? This sounds super strange. |
I have no idea, maybe someone on Slack or discourse could help? |
Asked on slack never got an answer. |
😞 |
I adopted what I already changed in Manopt.jl quite a while back