Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make.jl #766

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Refactor make.jl #766

merged 6 commits into from
Nov 6, 2024

Conversation

kellertuer
Copy link
Member

I adopted what I already changed in Manopt.jl quite a while back

  • more terminal ARGS can be passed now
  • tutorials can be excluded from the docs when not rendering quarto – for simplicity when someone just wants to fix typos or work un tutorial-unrelated stuff.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (cdfbe7f) to head (1885a4c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         124      124           
  Lines       11512    11512           
=======================================
  Hits        11099    11099           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
kellertuer and others added 2 commits November 6, 2024 20:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Mateusz Baran <[email protected]>
@kellertuer
Copy link
Member Author

And our News.md is out of sync, it states news for 0.10.6 which it seems are maybe part of 10.5? Will check tomorrow.

This does not need to be released as its own version and can chill on main for a while though. It is just nicer for new contributors.

@mateuszbaran
Copy link
Member

I forgot to bump version in Project.toml to 0.10.6 in the last PR so maybe let's release 0.10.6 after merging this PR?

@kellertuer
Copy link
Member Author

Sure, I adapted news and project.toml.

@kellertuer
Copy link
Member Author

The integration test is annoying me I can not find any hint how to fix that it fails. Why is the extension complaining having a package in its dependencies that it literally extends? This sounds super strange.

@mateuszbaran
Copy link
Member

I have no idea, maybe someone on Slack or discourse could help?

@kellertuer
Copy link
Member Author

Asked on slack never got an answer.

@mateuszbaran
Copy link
Member

😞

@kellertuer kellertuer merged commit d1d4166 into master Nov 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants