Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add segre and warped segre manifold #755

Merged
merged 42 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a35e472
add segre and warped segre manifold
Oct 2, 2024
9139574
added formulas to Segre manifold documentation
Oct 4, 2024
78ca0fd
Merge branch 'master' into sjacobsson/serge
kellertuer Oct 6, 2024
fd384fb
Setup docs, fix a few type errors, runs formatter.
kellertuer Oct 6, 2024
b34518e
Fix a bit of tests, version number and docs.
kellertuer Oct 6, 2024
b1417c1
Comment our tests so CI runs at least.
kellertuer Oct 6, 2024
2b2da05
runs formatter.
kellertuer Oct 6, 2024
f0d6624
added formulas in documentation
Oct 10, 2024
fc7a1b2
wrote tests for the Segre and the Segre with warped metric
Dec 6, 2024
d05eb4c
Merge branch 'master' into master
sjacobsson Dec 6, 2024
09e5207
formatting
Dec 6, 2024
6d6286e
Merge branch 'master' of github.com:sjacobsson/Manifolds.jl
Dec 6, 2024
269b137
Merge branch 'master' into sjacobsson/serge
kellertuer Dec 16, 2024
53a040e
fix Ronny's comments
Dec 17, 2024
0ac4c61
Merge branch 'master' into master
sjacobsson Dec 17, 2024
85919d2
Add test that get_coordinates(::Segre,...) and get_vector(::Segre,...…
Dec 17, 2024
8b90eb4
Merge remote-tracking branch 'refs/remotes/origin/master'
Dec 17, 2024
acfc752
Remove todos for Segre.
Dec 18, 2024
e6bf4a6
Fix inconsistencies in docstrings for Segre.
Dec 18, 2024
7079eef
formatting
Dec 18, 2024
1a2ce37
Fix codecov.
Dec 18, 2024
da09f54
A bit of markdown formatting, use UTF8 symbols where useful (in VS co…
kellertuer Dec 18, 2024
92ea877
Fix a typo.
kellertuer Dec 18, 2024
07dca08
Sponsor a nice show function.
kellertuer Dec 18, 2024
4620c18
Ooops. Deleted a parameter too much.
kellertuer Dec 18, 2024
f3a7f50
reduce magic numbers in testing and replace them by a bit more struct…
kellertuer Dec 19, 2024
c958bd2
Add Simon to the about page, adapt menu, wrap Segre test in a testset.
kellertuer Dec 19, 2024
2a1426b
Fix / re-add embed for tangent vectors. Unify test formatting
kellertuer Dec 19, 2024
e956159
Add link to Segre.
kellertuer Dec 19, 2024
25ece44
Move docstring from check_point and check_vector to is_point and is_v…
Dec 19, 2024
82f2c72
Test coverage for case in closest_representative! where given points …
Dec 19, 2024
0dab4f4
Update zenodo metadata.
kellertuer Dec 19, 2024
bd66d56
Add line about constructor in docstring for WarpedMetric.
Dec 19, 2024
e0e61a2
Actually test coverage for case in closest_representative! where give…
Dec 19, 2024
d11971c
Fix documentation
kellertuer Dec 19, 2024
5d8a4ba
bump documenter CI to Julia 1.11 as well.
kellertuer Dec 19, 2024
f41fece
add a show method for the warped metric so it prints nicer on REPL
kellertuer Dec 20, 2024
1f29ba8
Code golf in the segre tests. Also change a bunch of variable names a…
Dec 20, 2024
6d0db08
formatting
Dec 20, 2024
36b6afa
add news entry and date.
kellertuer Dec 20, 2024
341e913
Merge branch 'master' of github.com:sjacobsson/Manifolds.jl into sjac…
kellertuer Dec 20, 2024
a2413c5
small commit
Dec 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/documenter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
version: "1.6.38"
- uses: julia-actions/setup-julia@latest
with:
version: "1.10"
version: "1.11"
- name: Julia Cache
uses: julia-actions/cache@v2
- name: Cache Quarto
Expand Down
6 changes: 6 additions & 0 deletions .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
"name": "Weiß, Manuel",
"type": "ProjectMember"
},
{
"affiliation": "KU Leuven",
"name": "Jacobsson, Simon",
"orcid": "0000-0002-1181-972X",
"type": "ProjectMember"
},
{
"affiliation": "Georg-August-University Göttingen",
"name": "Klingbiel, Lukas",
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.10.9] - unreleased
## [0.10.9] - 2024-12-20

### Added

* the `Segre` manifold
* the `WarpedMetric` for the `Segre`manifold
* The manifold `HeisenbergMatrices` as the underlying manifold of `HeisenbergGroup`.

### Changed
Expand Down
26 changes: 0 additions & 26 deletions _quarto.yml

This file was deleted.

1 change: 1 addition & 0 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ makedocs(;
"Projective space" => "manifolds/projectivespace.md",
"Orthogonal and Unitary Matrices" => "manifolds/generalunitary.md",
"Rotations" => "manifolds/rotations.md",
"Segre" => "manifolds/segre.md",
"Shape spaces" => "manifolds/shapespace.md",
"Skew-Hermitian matrices" => "manifolds/skewhermitian.md",
"Spectrahedron" => "manifolds/spectrahedron.md",
Expand Down
31 changes: 31 additions & 0 deletions docs/src/manifolds/segre.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# The Segre manifold

```@docs
Segre
```

```@autodocs
Modules = [Manifolds]
Pages = ["manifolds/Segre.jl"]
Order = [:function]
```

## [A warped metric](@id segre-warped-metric-sec)

```@docs
WarpedMetric
```

```@autodocs
Modules = [Manifolds]
Pages = ["manifolds/SegreWarpedMetric.jl"]
Order = [:function]
```


## Literature

```@bibliography
Pages = ["segre.md"]
Canonical=false
```
1 change: 1 addition & 0 deletions docs/src/misc/about.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [Nick Dewaele](https://github.com/Nikdwal) contributed the [Tucker manifold](../manifolds/tucker.md)
- [Renée Dornig](https://github.com/r-dornig) contributed the [centered matrices](../manifolds/centeredmatrices.md) and the [essential manifold](../manifolds/essentialmanifold.md)
- [David Hong](https://github.com/dahong67) contributed uniform distributions on the Stiefel and Grassmann manifolds.
- [Simon Jacobsson](https://github.com/sjacobsson) contributed the [Segre manifold](../manifolds/segre.md) including its [warped metric](@ref segre-warped-metric-sec) thereon.
kellertuer marked this conversation as resolved.
Show resolved Hide resolved
- [Johannes Voll Kolstø](https://github.com/johannvk) contributed the [symplectic manifold](../manifolds/symplectic.md), the [symplectic Stiefel manifold](../manifolds/symplecticstiefel.md)
- [Manuel Weiß](https://github.com/manuelweisser) contributed [symmetric matrices](../manifolds/symmetric.md)

Expand Down
12 changes: 11 additions & 1 deletion docs/src/references.bib
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,16 @@ @article{HueperMarkinaSilvaLeite:2021
#
# J
# ----------------------------------------------------------------------------------------
@misc{JacobssonSwijsenVandervekenVannieuwenhoven:2024,
title={Warped geometries of Segre-Veronese manifolds},
author={Simon Jacobsson and Lars Swijsen and Joeri Van der Veken and Nick Vannieuwenhoven},
year={2024},
eprint={2410.00664},
archivePrefix={arXiv},
primaryClass={math.NA},
url={https://arxiv.org/abs/2410.00664},
}

@article{JourneeBachAbsilSepulchre:2010,
DOI = {10.1137/080731359},
EPRINT = {0807.4423},
Expand Down Expand Up @@ -951,4 +961,4 @@ @article{AastroemPetraSchmitzerSchnoerr:2017
AUTHOR = {Freddie Åström and Stefania Petra and Bernhard Schmitzer and Christoph Schnörr},
TITLE = {Image Labeling by Assignment},
JOURNAL = {Journal of Mathematical Imaging and Vision}
}
}
1 change: 1 addition & 0 deletions docs/styles/config/vocabularies/Manifolds/accept.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Grassmann
[Jj]ulia
Riemannian
Segre
Stiefel
[sS]ymplectic
struct
7 changes: 6 additions & 1 deletion src/Manifolds.jl
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,8 @@ include("manifolds/MultinomialSymmetric.jl")
include("manifolds/MultinomialSymmetricPositiveDefinite.jl")
include("manifolds/PositiveNumbers.jl")
include("manifolds/ProjectiveSpace.jl")
include("manifolds/Segre.jl")
include("manifolds/SegreWarpedMetric.jl")
include("manifolds/SkewHermitian.jl")
include("manifolds/Spectrahedron.jl")
include("manifolds/Stiefel.jl")
Expand Down Expand Up @@ -660,6 +662,7 @@ export Euclidean,
ProbabilitySimplex,
ProjectiveSpace,
Rotations,
Segre,
SkewHermitianMatrices,
SkewSymmetricMatrices,
Spectrahedron,
Expand Down Expand Up @@ -738,7 +741,8 @@ export AbstractMetric,
ProductMetric,
RealSymplecticMetric,
RiemannianMetric,
StiefelSubmersionMetric
StiefelSubmersionMetric,
WarpedMetric
export AbstractAtlas, RetractionAtlas
# Vector transport types
export AbstractVectorTransportMethod, ParallelTransport, ProjectionTransport
Expand Down Expand Up @@ -807,6 +811,7 @@ export ×,
christoffel_symbols_first,
christoffel_symbols_second,
christoffel_symbols_second_jacobian,
connected_by_geodesic,
convert,
complex_dot,
decorated_manifold,
Expand Down
Loading
Loading