-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupManifold accepts two arguments #747
GroupManifold accepts two arguments #747
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 123 123
Lines 11415 11418 +3
=======================================
+ Hits 11380 11383 +3
Misses 35 35 ☔ View full report in Codecov by Sentry. |
Looks reasonable to me. Thanks :) Could you wait a bit for #748, then add this as an entry to the changelog (including setting the date); and bump the version in the project toml? Then wo could register this as 0.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, I'd only adding this default value to the docstring of GroupManifold
and changelog.
Co-authored-by: Mateusz Baran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
The default representation for GroupManifold is
LeftInvariantRepresentation
, this ensures backward compatibility with previous versions ofManifolds.jl