Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupManifold accepts two arguments #747

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

olivierverdier
Copy link
Contributor

@olivierverdier olivierverdier commented Sep 14, 2024

The default representation for GroupManifold is LeftInvariantRepresentation, this ensures backward compatibility with previous versions of Manifolds.jl

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (11f0a6c) to head (58698db).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         123      123           
  Lines       11415    11418    +3     
=======================================
+ Hits        11380    11383    +3     
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member

Looks reasonable to me. Thanks :) Could you wait a bit for #748, then add this as an entry to the changelog (including setting the date); and bump the version in the project toml? Then wo could register this as 0.10.2

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, I'd only adding this default value to the docstring of GroupManifold and changelog.

src/groups/GroupManifold.jl Outdated Show resolved Hide resolved
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mateuszbaran mateuszbaran merged commit 315601e into JuliaManifolds:master Sep 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants