Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix FiniteDifferences + SArray failure #729

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Trying to fix FiniteDifferences + SArray failure #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0c60f2
Trying to fix FiniteDifferences + SArray failure
mateuszbaran Jun 10, 2024
e26157b
bump ambiguities :(
mateuszbaran Jun 10, 2024
1fe101b
Merge branch 'master' into mbaran/fix-fd-failure
mateuszbaran Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/manifolds/MetricManifold.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@
backend::AbstractDiffBackend=default_differential_backend(),
)
n = size(p, 1)
∂g = reshape(_jacobian(q -> local_metric(M, q, B), p, backend), n, n, n)
∂g = reshape(_jacobian(q -> local_metric(M, q, B), copy(M, p), backend), n, n, n)

Check warning on line 490 in src/manifolds/MetricManifold.jl

View check run for this annotation

Codecov / codecov/patch

src/manifolds/MetricManifold.jl#L490 

Added line #L490 was not covered by tests
return ∂g
end
@trait_function local_metric_jacobian(
Expand Down
4 changes: 2 additions & 2 deletions test/ambiguities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ end
# Interims solution until we follow what was proposed in
# https://discourse.julialang.org/t/avoid-ambiguities-with-individual-number-element-identity/62465/2
fmbs = filter(x -> !any(has_type_in_signature.(x, Identity)), mbs)
FMBS_LIMIT = 34
FMBS_LIMIT = 38
println("Number of ManifoldsBase.jl ambiguities: $(length(fmbs))")
@test length(fmbs) <= FMBS_LIMIT
if length(fmbs) > FMBS_LIMIT
Expand All @@ -30,7 +30,7 @@ end
# Interims solution until we follow what was proposed in
# https://discourse.julialang.org/t/avoid-ambiguities-with-individual-number-element-identity/62465/2
fms = filter(x -> !any(has_type_in_signature.(x, Identity)), ms)
FMS_LIMIT = 47
FMS_LIMIT = 53
println("Number of Manifolds.jl ambiguities: $(length(fms))")
if length(fms) > FMS_LIMIT
for amb in fms
Expand Down
Loading