Adapt to recent vee/hat change in ManifoldsBase #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
added
Ready-for-Review
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 108 108
Lines 10678 10678
==========================================
- Hits 10633 10632 -1
- Misses 45 46 +1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Looks good in general to me, besides the loss of one line in codecov? |
|
That looks completely unrelated to this PR, so I'd ignore it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaManifolds/ManifoldsBase.jl#173 broke some tests here and this fixes them.