-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of the orthographic retraction for the fixed rank manifold #662
Introduction of the orthographic retraction for the fixed rank manifold #662
Conversation
…and already 2 new references.
Use the right math environment and disentangle markdown notation and LaTeX notation.
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 108 108
Lines 10567 10593 +26
=======================================
+ Hits 10504 10530 +26
Misses 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution! I've left a few small comments.
# Conflicts: # src/manifolds/FixedRankMatrices.jl
Since we had some (breaking) changes in ManifoldsBase (concerning especially the data flow / allocation flow for retractions) and Manifolds (concerning statically parametrised manifolds) I just adapted this PR to those changes. @Klingbiel could you check the comments above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be resolved – I just did a final commit with
a) Updating (bump) the version number
b) adding an entry to our changelog (NEWS.md)
Great to see further people contributing to Manifolds.jl, danke Lukas!
As soon as tests pass here, I will merge this and register a new version.
No description provided.