Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of the orthographic retraction for the fixed rank manifold #662

Merged
merged 19 commits into from
Oct 25, 2023

Conversation

Klingbiel
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #662 (62dcf0e) into master (3536123) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10567    10593   +26     
=======================================
+ Hits        10504    10530   +26     
  Misses         63       63           
Files Coverage Δ
ext/ManifoldsTestExt/tests_general.jl 95.72% <100.00%> (+0.04%) ⬆️
src/Manifolds.jl 86.66% <ø> (ø)
src/manifolds/FixedRankMatrices.jl 98.88% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Oct 20, 2023
Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! I've left a few small comments.

src/manifolds/FixedRankMatrices.jl Outdated Show resolved Hide resolved
src/manifolds/FixedRankMatrices.jl Outdated Show resolved Hide resolved
src/manifolds/FixedRankMatrices.jl Outdated Show resolved Hide resolved
src/manifolds/FixedRankMatrices.jl Outdated Show resolved Hide resolved
src/manifolds/FixedRankMatrices.jl Show resolved Hide resolved
# Conflicts:
#	src/manifolds/FixedRankMatrices.jl
@kellertuer
Copy link
Member

Since we had some (breaking) changes in ManifoldsBase (concerning especially the data flow / allocation flow for retractions) and Manifolds (concerning statically parametrised manifolds) I just adapted this PR to those changes.

@Klingbiel could you check the comments above?

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be resolved – I just did a final commit with

a) Updating (bump) the version number
b) adding an entry to our changelog (NEWS.md)

Great to see further people contributing to Manifolds.jl, danke Lukas!

As soon as tests pass here, I will merge this and register a new version.

@kellertuer kellertuer merged commit b0ab892 into JuliaManifolds:master Oct 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants