-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random point / vector allocations #653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 99.22% 99.18% -0.04%
==========================================
Files 106 106
Lines 10433 10440 +7
==========================================
+ Hits 10352 10355 +3
- Misses 81 85 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For positive numbers the problem was, that the allocating version has to return a number and can not allocate anything, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe up to the point that we still might want to have in-place rand!
for PositiveNumbers
?
Sure, then we just have to check that it is also covered by tests, the new (allocating) one basically covers all cases we currently have in the tests. edit: Had an idea, stole the zero-dimensional arrays from the circle and added both |
The new four uncovered lines are false positives (function headers but the functions are green |
This is the companion PR to JuliaManifolds/ManifoldsBase.jl#168 to fix using TangentSpaceAtPoint on non-matrix-type manifolds.
Resolves #652