Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup of vector bundles #641

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

mateuszbaran
Copy link
Member

A small cleanup plus making them a bit more extensible.

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Jul 7, 2023
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #641 (90b7243) into master (e714d9d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   99.01%   98.98%   -0.04%     
==========================================
  Files         106      106              
  Lines       10201    10202       +1     
==========================================
- Hits        10101    10098       -3     
- Misses        100      104       +4     
Impacted Files Coverage Δ
src/manifolds/VectorBundle.jl 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mateuszbaran mateuszbaran merged commit 4b80c6e into master Jul 7, 2023
@kellertuer kellertuer deleted the mbaran/vector-bundle-minor-improvements branch May 4, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants