Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rotations(1) #636

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Fix Rotations(1) #636

merged 4 commits into from
Jun 26, 2023

Conversation

mateuszbaran
Copy link
Member

Fixes #635 and some related issues.

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #636 (dd75d8b) into master (d24f6d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         106      106           
  Lines       10187    10198   +11     
=======================================
+ Hits        10087    10098   +11     
  Misses        100      100           
Impacted Files Coverage Δ
src/manifolds/GeneralUnitaryMatrices.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mateuszbaran
Copy link
Member Author

This is a small bugfix, so I'd like to merge it when CI passes.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mateuszbaran mateuszbaran merged commit e714d9d into master Jun 26, 2023
@kellertuer kellertuer deleted the mbaran/rotations-1 branch May 4, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault calling get_vector_orthogonal
2 participants