Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better consistency with the blue style #317

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Conversation

mateuszbaran
Copy link
Member

I've added a few more rules that are now available in JuliaFormatter for the Blue Style. whitespace_in_kwargs = false has the biggest impact here.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #317 (c3c1370) into master (29a998a) will not change coverage.
The diff coverage is 94.53%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          69       69           
  Lines        4646     4646           
=======================================
  Hits         4459     4459           
  Misses        187      187           
Impacted Files Coverage Δ
src/Manifolds.jl 100.00% <ø> (ø)
src/differentiation.jl 100.00% <ø> (ø)
src/groups/array_manifold.jl 100.00% <ø> (ø)
src/groups/group.jl 92.75% <ø> (ø)
src/groups/group_action.jl 92.00% <ø> (ø)
src/groups/group_operation_action.jl 100.00% <ø> (ø)
src/groups/metric.jl 93.61% <ø> (ø)
src/groups/rotation_action.jl 100.00% <ø> (ø)
src/groups/translation_action.jl 100.00% <ø> (ø)
src/groups/translation_group.jl 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a998a...c3c1370. Read the comment docs.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for updating. I hope they finish their Blue Style issue soon, so that it will be just style=Blue in the .toml. Optimistic as I was, I started with that in Manopt.jl a while back.

@mateuszbaran
Copy link
Member Author

There is still quite a lot of missing things unfortunately: domluna/JuliaFormatter.jl#283 so for now style=Blue doesn't look like a good idea.

@mateuszbaran mateuszbaran merged commit a6adb1c into master Dec 22, 2020
@kellertuer kellertuer deleted the mbaran/more-blue-style branch August 2, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants