Code

Poincaré models for Hyperbolic space#219

Code

Merged

kellertuer merged 40 commits intomasterJuliaManifolds/Manifolds.jl:masterfrom kellertuer/HyperbolicRepresentationsJuliaManifolds/Manifolds.jl:kellertuer/HyperbolicRepresentationsCopy head branch name to clipboardSep 22, 2020

+1,213-137

Commits

Commits on Sep 10, 2020

• initial sketch of multiple representations of Hyperbolic.

  kellertuer

  committed
  fa8b8ff

  Copy full SHA for fa8b8ff

• finishes all conversion methods.

  kellertuer

  committed
  0166fd0

  Copy full SHA for 0166fd0

• test coverage for conversions, reduce ambiguities.

  kellertuer

  committed
  0343794

  Copy full SHA for 0343794

• adds a few more tests.

  kellertuer

  committed
  1063e02

  Copy full SHA for 1063e02

Commits on Sep 11, 2020

• extends testing to new types (note that convert also converts representations) – starts allocations and such.

  kellertuer

  committed
  493766e

  Copy full SHA for 493766e

• fixing method definitions inside a loop

  mateuszbaran

  committed
  589893e

  Copy full SHA for 589893e

• tries to adapt allocate_result_type.

  kellertuer

  committed
  8419068

  Copy full SHA for 8419068

• introduces log/exp/inner/inverse retract.

  kellertuer

  committed
  b8e650a

  Copy full SHA for b8e650a

• finish zero_tangent, specify tests.

  kellertuer

  committed
  a8ab783

  Copy full SHA for a8ab783

• fixes a typo.

  kellertuer

  committed
  a0bc91d

  Copy full SHA for a0bc91d

Commits on Sep 12, 2020

• 3 of 4 of the most important tangent conversions.

  kellertuer

  committed
  51ad811

  Copy full SHA for 51ad811

• rearrange and split code to have smaller files. conversions are with the representation they convert into.

  kellertuer

  committed
  f6d9b9a

  Copy full SHA for f6d9b9a

• introduces the conversions that will be done via proxy.

  kellertuer

  committed
  188ef02

  Copy full SHA for 188ef02

• implements the last push forward, deactivates a few broadcasting tests for the new data types.

  kellertuer

  committed
  8077e07

  Copy full SHA for 8077e07

• fixes a few conversions.

  kellertuer

  committed
  44e09a0

  Copy full SHA for 44e09a0

• implements the final conversion.

  kellertuer

  committed
  64a55c8

  Copy full SHA for 64a55c8

• fixes tests – though there are a few to fix in exp/log.

  kellertuer

  committed
  dbe4482

  Copy full SHA for dbe4482

Commits on Sep 13, 2020

• allow for 24 (instead of 21) ambiguities, since we have 3 more conversions that are ambiguous with StaticArrays.

  kellertuer

  committed
  00fecab

  Copy full SHA for 00fecab

• debug the new formulae (part 1).

  kellertuer

  committed
  5813f62

  Copy full SHA for 5813f62

• First thorough check of half space points – they are correct, the error seems to be in the tangent transforms.

  kellertuer

  committed
  7f69cd0

  Copy full SHA for 7f69cd0

• Fixes an off-by-one error (or mixing up multiplying out a binomial vs not doing it).

  kellertuer

  committed
  6bf5ed6

  Copy full SHA for 6bf5ed6

• unify conversions and adds a test that converts everything to everything.

  kellertuer

  committed
  940c3be

  Copy full SHA for 940c3be

Commits on Sep 14, 2020

• removes and already implemented conversion (identity) and fixes a bug on embedding HyperboloidPoints / TVectors – increases code coverage.

  kellertuer

  committed
  0b0f1a9

  Copy full SHA for 0b0f1a9

• adapt spacing.

  kellertuer

  committed
  4b5f5b0

  Copy full SHA for 4b5f5b0

• adresses a point from code review and fixes a bug from copy paste introducing all conversions.

  kellertuer

  committed
  527ac39

  Copy full SHA for 527ac39

• fixes a few things from code review.

  kellertuer

  committed
  3a587e0

  Copy full SHA for 3a587e0

• did not save formatter changes...

  kellertuer

  committed
  0ddf9ce

  Copy full SHA for 0ddf9ce

• Update src/manifolds/HyperbolicPoincareHalfspace.jl

  Show description for b04546f
  

  kellertuer

  and

  mateuszbaran

  authored
  b04546f

  Copy full SHA for b04546f

• Refactor Hyperbolic to be denoted by \mathcal H^n; adds a few docstrings in the tests, for example for in().

  kellertuer

  committed
  cc0d911

  Copy full SHA for cc0d911

• fix nightly tests.

  kellertuer

  committed
  9e897fc

  Copy full SHA for 9e897fc

• fix notations documentation.

  kellertuer

  committed
  d42a9da

  Copy full SHA for d42a9da

Commits on Sep 18, 2020

• refactor the conversion to tangent vectors to be a 3-argument convert.

  kellertuer

  committed
  57b1466

  Copy full SHA for 57b1466

• adds a missing alllocation type and allow projections only for fitting types.

  kellertuer

  committed
  2695e81

  Copy full SHA for 2695e81

• reduce ambiguities, since this was increased by the removed tuple conversions.

  kellertuer

  committed
  0fab4bb

  Copy full SHA for 0fab4bb

Commits on Sep 21, 2020

• update ManifoldsBase dependency to most recent version.

  kellertuer

  committed
  b685fb3

  Copy full SHA for b685fb3

• adapt formatting to new vector format rule in JuliaFormatter

  kellertuer

  committed
  77092f9

  Copy full SHA for 77092f9

• Apply suggestions from code review

  Show description for a6936b5
  

  kellertuer

  and

  mateuszbaran

  authored
  a6936b5

  Copy full SHA for a6936b5

• more consistently name points p.

  kellertuer

  committed
  3c9c2d0

  Copy full SHA for 3c9c2d0

• trying to skip a Julia bug

  mateuszbaran

  committed
  f09beb9

  Copy full SHA for f09beb9

• tweaking conversion in hyperbolic

  mateuszbaran

  committed
  839e122

  Copy full SHA for 839e122