Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper errors on Power and Product #210

Merged
merged 15 commits into from
Aug 6, 2020
Merged

Conversation

kellertuer
Copy link
Member

To continue #207 this PR introduces two special error types for composite manifolds like power and product: the ComponentManifoldError consists of an error and an index, where this error occurred,
the CompositeManifoldError collects a set of these if there is more than one error.

Maybe a separate docs page would be still nice.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #210 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   95.03%   95.12%   +0.09%     
==========================================
  Files          63       64       +1     
  Lines        3744     3774      +30     
==========================================
+ Hits         3558     3590      +32     
+ Misses        186      184       -2     
Impacted Files Coverage Δ
src/Manifolds.jl 100.00% <ø> (ø)
src/errors.jl 100.00% <100.00%> (ø)
src/manifolds/MultinomialDoublyStochastic.jl 100.00% <100.00%> (ø)
src/manifolds/PowerManifold.jl 95.91% <100.00%> (+0.04%) ⬆️
src/manifolds/ProductManifold.jl 89.65% <100.00%> (+0.08%) ⬆️
src/manifolds/Euclidean.jl 91.86% <0.00%> (+0.09%) ⬆️
src/groups/group.jl 77.77% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d15172...682f4d4. Read the comment docs.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Aug 6, 2020
@kellertuer kellertuer merged commit 6b97d50 into master Aug 6, 2020
@kellertuer kellertuer deleted the improve-errors-and-prints branch August 7, 2020 07:48
@kellertuer kellertuer removed the Ready-for-Review A label for pull requests that are feature-ready label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants