-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper errors on Power and Product #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 95.03% 95.12% +0.09%
==========================================
Files 63 64 +1
Lines 3744 3774 +30
==========================================
+ Hits 3558 3590 +32
+ Misses 186 184 -2
Continue to review full report at Codecov.
|
mateuszbaran
reviewed
Aug 6, 2020
kellertuer
added
the
Ready-for-Review
A label for pull requests that are feature-ready
label
Aug 6, 2020
mateuszbaran
reviewed
Aug 6, 2020
mateuszbaran
approved these changes
Aug 6, 2020
kellertuer
removed
the
Ready-for-Review
A label for pull requests that are feature-ready
label
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue #207 this PR introduces two special error types for composite manifolds like power and product: the
ComponentManifoldError
consists of an error and an index, where this error occurred,the
CompositeManifoldError
collects a set of these if there is more than one error.Maybe a separate docs page would be still nice.