Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposes a tutorial on how to implement a manifold #190

Merged
merged 13 commits into from
May 20, 2020

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented May 16, 2020

My aim is to maybe slowly extend this and write more tutorials in forthcoming PRs.

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #190 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   94.37%   94.30%   -0.08%     
==========================================
  Files          50       50              
  Lines        3201     3212      +11     
==========================================
+ Hits         3021     3029       +8     
- Misses        180      183       +3     
Impacted Files Coverage Δ
src/manifolds/Sphere.jl 97.72% <ø> (+0.08%) ⬆️
src/manifolds/Symmetric.jl 96.82% <0.00%> (-1.59%) ⬇️
src/manifolds/Euclidean.jl 91.86% <0.00%> (-0.92%) ⬇️
src/groups/metric.jl 84.61% <0.00%> (-0.76%) ⬇️
src/manifolds/PowerManifold.jl 95.83% <0.00%> (-0.45%) ⬇️
src/Manifolds.jl 100.00% <0.00%> (ø)
src/manifolds/GeneralizedStiefel.jl 100.00% <0.00%> (ø)
src/manifolds/GeneralizedGrassmann.jl 100.00% <0.00%> (ø)
src/manifolds/Circle.jl 99.23% <0.00%> (+0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97d69e...f3b7249. Read the comment docs.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea 👍 . I left a few comments and I'll look at it again later.

docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Outdated Show resolved Hide resolved
docs/src/tutorials/manifold.md Show resolved Hide resolved
@kellertuer
Copy link
Member Author

Thanks, I'll merge this so it's on dev and with the next feature it'll be on the main docs then.

@kellertuer kellertuer merged commit 4350aef into master May 20, 2020
@kellertuer kellertuer deleted the rbergmann/manifold-tutorial branch August 7, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants